Remove spurious pytest.warns() to fix pytest-8 compatibility
#790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the spurious `pytest.warns()` contexts within `pytest.raises()` in `test_shortcuts`, in order to fix compatibility with pytest-8.0.0. Prior to this version, the exception raised caused these assertions to be ignored entirely. This is fixed in pytest-8.0.0, and the tests start failing because the warning is never raised prior to the exception. Fixes python-openapi#789
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #790 +/- ##
==========================================
- Coverage 90.58% 90.37% -0.22%
==========================================
Files 139 143 +4
Lines 4207 4228 +21
Branches 514 515 +1
==========================================
+ Hits 3811 3821 +10
- Misses 301 311 +10
- Partials 95 96 +1 ☔ View full report in Codecov by Sentry. |
p1c2u
approved these changes
Feb 15, 2024
|
Thanks for the fix |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the spurious
pytest.warns()contexts withinpytest.raises()intest_shortcuts, in order to fix compatibility with pytest-8.0.0. Prior to this version, the exception raised caused these assertions to be ignored entirely. This is fixed in pytest-8.0.0, and the tests start failing because the warning is never raised prior to the exception.Fixes #789