Skip to content

typing - binlogstream.py #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2023
Merged

typing - binlogstream.py #79

merged 5 commits into from
Sep 2, 2023

Conversation

starcat37
Copy link
Member

@starcat37 starcat37 commented Aug 31, 2023 •
edited
Loading

TODO

  • 테스트: 정상 작동 확인
  • 호환성: pytest
  • 누락된 typing 확인
  • 잘못된 typing 확인
  • docstring 수정

@starcat37 starcat37 added the 3조 3조 만세 label Aug 31, 2023
@starcat37 starcat37 self-assigned this Aug 31, 2023
@starcat37 starcat37 changed the title Refactor: add typing to binlogstream.py typing - binlogstream.py Aug 31, 2023
dongwook-chan
dongwook-chan approved these changes Sep 1, 2023
View reviewed changes
Copy link

@dongwook-chan dongwook-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing 꼼꼼하게 정말 잘 적용해주셨습니다! 고생 많으셨습니다!! 👍🏻👍🏻👍🏻

@starcat37 starcat37 marked this pull request as ready for review September 1, 2023 09:31
heehehe
heehehe approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@heehehe heehehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import된 typing 종류가 많은 것부터 노력하신 흔적이 느껴지네요..!!🥺
매번 꼼꼼히 작업하시는 모습 통해 많이 배우고 있습니다ㅎㅎ 고생 많으셨습니다!😃

@starcat37
Copy link
Member Author

starcat37 commented Sep 2, 2023 •
edited
Loading

세 분 approve해주셔서 머지할게요...!! 다들 정말 감사합니다🥰🥰

@starcat37 starcat37 merged commit 028aba1 into feature/typing-packet-gtid-binlogstream Sep 2, 2023
@starcat37 starcat37 deleted the feature/typing-binlogstream branch September 2, 2023 04:31
@starcat37 starcat37 restored the feature/typing-binlogstream branch September 2, 2023 04:31
@starcat37 starcat37 deleted the feature/typing-binlogstream branch September 2, 2023 04:32
This was referenced Sep 2, 2023
Merged
Closed
heehehe added a commit that referenced this pull request Sep 2, 2023
@heehehe
fix: add Type to allowed_events
daa12bd 
#79 (comment)
@heehehe heehehe restored the feature/typing-binlogstream branch September 5, 2023 01:06
@heehehe heehehe mentioned this pull request Sep 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heehehe heehehe heehehe approved these changes

@dongwook-chan dongwook-chan dongwook-chan approved these changes

@mjs1995 mjs1995 mjs1995 approved these changes

@sean-k1 sean-k1 Awaiting requested review from sean-k1

@mikaniz mikaniz Awaiting requested review from mikaniz

Assignees

@starcat37 starcat37

Labels
3조 3조 만세
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@starcat37 @dongwook-chan @heehehe @mjs1995