Skip to content

typing - gtid.py #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2023
Merged

typing - gtid.py #76

merged 3 commits into from
Aug 31, 2023

Conversation

mjs1995
Copy link
Member

@mjs1995 mjs1995 commented Aug 30, 2023 •
edited by mikaniz
Loading

TODO - class Gtid

  • 테스트: 정상 작동 확인
  • 호환성: pytest
  • 누락된 typing 확인

TODO - class GtidSet

  • 테스트: 정상 작동 확인
  • 호환성: pytest
  • 누락된 typing 확인

@mjs1995 mjs1995 added the 3조 3조 만세 label Aug 30, 2023
@mjs1995 mjs1995 marked this pull request as draft August 30, 2023 13:53
@mikaniz mikaniz marked this pull request as ready for review August 30, 2023 23:04
heehehe
heehehe approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@heehehe heehehe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!! merge하실 때 Squash and merge로, 커밋 메시지는 docs: add typing gtid.py 등으로 부탁드립니다!
image

pymysqlreplication/gtid.py Outdated

Raises:
Exception: if the attempted merge has different SID"""
Exception: if the attempted merge has different SID
"""
Copy link
Member

@heehehe heehehe Aug 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 """ 부분 indentation이 위의 """랑 맞아야할 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heehehe 수정했습니다!
확인해줘서 감사합니다 👍

@mjs1995 mjs1995 merged commit 12ba2fa into feature/typing-packet-gtid-binlogstream Aug 31, 2023
This was referenced Sep 2, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heehehe heehehe heehehe approved these changes

@sean-k1 sean-k1 Awaiting requested review from sean-k1

@dongwook-chan dongwook-chan Awaiting requested review from dongwook-chan

@starcat37 starcat37 Awaiting requested review from starcat37

@mikaniz mikaniz Awaiting requested review from mikaniz

Assignees

@mjs1995 mjs1995

@mikaniz mikaniz

Labels
3조 3조 만세
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjs1995 @heehehe @mikaniz