Skip to content

typing - exceptions.py #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 31, 2023
Merged

typing - exceptions.py #74

merged 5 commits into from
Aug 31, 2023

Conversation

starcat37
Copy link
Member

@starcat37 starcat37 commented Aug 30, 2023 •
edited by mjs1995
Loading

TODO

  • 테스트: 정상 작동 확인
  • 호환성: pytest
  • 누락된 typing 확인

@starcat37 starcat37 added the 3조 3조 만세 label Aug 30, 2023
@starcat37 starcat37 marked this pull request as ready for review August 30, 2023 07:11
@starcat37 starcat37 self-assigned this Aug 30, 2023
heehehe
heehehe approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@heehehe heehehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!! merge하실 때 Squash and merge로, 커밋 메시지는 docs: add typing in exceptions.py 등으로 부탁드립니다!
image

@starcat37 starcat37 merged commit cb129a5 into feature/typing-packet-gtid-binlogstream Aug 31, 2023
@starcat37 starcat37 deleted the feature/typing-exceptions branch August 31, 2023 13:10
@heehehe heehehe mentioned this pull request Sep 2, 2023
Closed
@heehehe heehehe restored the feature/typing-exceptions branch September 5, 2023 01:06
@heehehe heehehe mentioned this pull request Sep 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heehehe heehehe heehehe approved these changes

@mjs1995 mjs1995 mjs1995 approved these changes

@sean-k1 sean-k1 Awaiting requested review from sean-k1

@dongwook-chan dongwook-chan Awaiting requested review from dongwook-chan

@mikaniz mikaniz Awaiting requested review from mikaniz

Assignees

@starcat37 starcat37

Labels
3조 3조 만세
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@starcat37 @heehehe @mjs1995