-
-
Notifications
You must be signed in to change notification settings - Fork 593
Add extra_info on ValidationError for required missing property #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #856 +/- ##
==========================================
+ Coverage 98.29% 98.31% +0.01%
==========================================
Files 19 19
Lines 3111 3144 +33
Branches 377 379 +2
==========================================
+ Hits 3058 3091 +33
Misses 41 41
Partials 12 12
Continue to review full report at Codecov.
|
Thanks! I'll leave detailed notes in a bit, but really happy to see this getting addressed. Two immediate things:
|
Yes, I will check them out. |
I looked only into: Or would you like all named properties to have the |
No I just meant those indeed! That sounds great, will have a look. |
@TsankoBg with sincere apologies (since you yourself did everything right here), some other things have recently convinced me to bite the bullet on finally doing #119 (comment) (i.e. doing this via separating out |
This PR adds an
extra_info
attribute onValidationError
, which is used to indicate the missing property in errors from therequired
validator.This should resolve issue #119, and can be used for adding details to other validators as well, in the future.