Skip to content

[compat] Drop support of PY2 #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

Djailla
Copy link

@Djailla Djailla commented Jul 22, 2020

Allowing to drop six requirement

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #709 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files          18       18           
  Lines        2716     2717    +1     
  Branches      321      321           
=======================================
+ Hits         2587     2588    +1     
  Misses        106      106           
  Partials       23       23           
Impacted Files Coverage Δ
jsonschema/cli.py 96.94% <ø> (-0.03%) ⬇️
jsonschema/validators.py 94.65% <100.00%> (-0.07%) ⬇️
jsonschema/tests/test_jsonschema_test_suite.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd31840...027feac. Read the comment docs.

@Djailla
Copy link
Author

Djailla commented Jul 23, 2020

Hello @Julian

The CI is marked as red due to coverage, but you could be interested ?

@Julian
Copy link
Member

Julian commented Jul 26, 2020

@Djailla hi! Yes, thanks for sending it.

This likely is something I'll want to do in the next few months, but there's likely a few things higher on the list for limited time :/ -- the one thing I see is we need to set a python_requires in the setup.cfg as part of this change, so that we don't break Python 2 for any existing versions.

But beyond that yes would be interested, just may take me a bit to get to this.

Thanks for sending it!

Allowing to drop six requirement
@Julian Julian merged commit 8a9852e into python-jsonschema:master Aug 4, 2020
@Julian
Copy link
Member

Julian commented Aug 4, 2020

Merged, thanks!

@sloanlance
Copy link

sloanlance commented Aug 4, 2020

Awesome! This solves a lot of the headaches I was having with #708 (PR #712)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants