Fix unclosed resource in validators #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Really appreciated. Could you write a test to ensure this doesn't regress? |
|
@Julian I fixed and extended an already existing test to check for context manager's calls. If there is still something lacking please let me know. |
Julian
reviewed
Jul 12, 2018
| (resource_manager_mock. | ||
| __enter__.return_value. | ||
| read.return_value. | ||
| decode.return_value) = json.dumps(schema).encode("utf8") |
There was a problem hiding this comment.
This doesn't look correct, and is a good example of why mocking is sadness :/
decode returns unicode, not bytes.
Will fix on merge though, thanks.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource used by
urlopenwas never explicitly closed, running an app with pythons-W allflag raised loads ofResourceWarnings. Using a context manager is a simple fix.