Fix: Convert properties to string before regex #401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not uncommon for developers to create schemas in YAML, for example when developing an Open API Specification. When keys are numeric and parsed with the yaml parser they are typed and throw an error when attempting to validate patternProperties or similar pattern matching validation. This changeset converts the property to a string before attempting to match the regex.
|
(for which by the way my opinion at the minute is still that this should be up to the deserializer totake care of immediately after deserializing) |
|
Sounds fair. I'll move down stream to open API validator that lead me here in the first place and probably round trip yaml to JSON. The Type Error was cryptic and annoying, but again more of a down stream issue. |
|
Great!
…On Wed, Apr 25, 2018, 20:29 Grant Callaghan ***@***.***> wrote:
Closed #401 <#401>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#401 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAUIXjmw045Yk_YrbEDOaJ3Lh2FJgJ_Oks5tsRT_gaJpZM4TkIXK>
.
|
Julian
added a commit
that referenced
this pull request
Jun 20, 2020
fc05651cc Merge pull request #409 from Stranger6667/dd/add-jsonschema-rs 5f1575a93 Add Rust `jsonschema` crate 2bf95beec Merge pull request #407 from fisxoj/master 9ae956b21 Add common lisp implementation to the list d4ffd569b Merge pull request #401 from json-schema-org/ether/format-uuid 2d6c45711 tests for the "uuid" format 08f6cdaff Merge pull request #400 from json-schema-org/ether/more-format-ipv6 d3064eb3a some more tests for the "ipv6" format 1f34d3321 Merge pull request #399 from json-schema-org/ether/more-format-idn-email 22adda78c also test the "email" inputs against "idn-email" 25598a3b4 Merge pull request #392 from rjmill/rjmill/test-prop-named-ref-containing-a-ref 8dfa8adc9 Merge pull request #380 from ChALkeR/fix-ecmascript-regex d595dbf9d backport $ref cases, changing "$defs" to "definitions" ca8319c9e Fix \W test description 452b5f8f4 Test property named $ref, containing an actual $ref a01ae5404 Fix ECMA 262 regex whitespace tests. git-subtree-dir: json git-subtree-split: fc05651cce3889975f8dbcca38c203d6a396694b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not uncommon for developers to create schemas in YAML, for example
when developing an Open API Specification. When keys are numeric and
parsed with the yaml parser they are typed and throw an error when
attempting to validate patternProperties or similar pattern matching
validation. This changeset converts the property to a string before
attempting to match the regex.