Skip to content

Add path into extras #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gdassori
Copy link

Invalidating extras doesn't provide the involved property name into ValidationError.path, as other validators seems do.

Invalidating extras doesn't provide the involved property name into ValidationError.path, as other validators seems do.
@Julian
Copy link
Member

Julian commented Oct 25, 2015

Hey! Thanks so much for the PR.

The path attribute is supposed to be the path into the instance where the error occurred. That isn't the case here, you're passing a set of property names to it (not a tuple, by the way, in case that was what you meant).

There's an issue that's been open to add support for an extra_information field on ValidationErrors in #119 which you might be interested in, that would cover this case. I'm going to close this as a duplicate but feel free to follow up over there if you're interested. Thanks again!

@Julian Julian closed this Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants