-
-
Notifications
You must be signed in to change notification settings - Fork 593
Fixed #134 -- Added CLI interface #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey, thanks, sorry I haven't gotten a chance to take a look at this yet, but I do agree it'd be nice to have. I'll try and take a look before the end of the week. |
Sorry it took me this look to look :) Thanks for submitting this – would you be interested in writing a few small tests for the functionality here, if it's something that we're gonna actually support going forward it'd be nice to make sure it continues to work as we evolve it? Also I see that you're outputting some non-ASCII characters which are UTF-8. Have a feeling that's going to cause issues for windows users who might want to use this. And the use of |
I've updated the PR to include unit tests and removed the UTF-8 character. I spend the better part of my time figuring out py.test (mostly getting it to not capture output when I wanted to see it and failing to capture output when I wanted to). But I think the tests are quite complete as-is. I don't see how the issue of entry points can be resolved. I haven't updated myself on the whole wheel movement, maybe you could shine a light? http://wheel.readthedocs.org/en/latest/#setuptools-scripts-handling |
I'll investigate why |
The failing test doesn't appear to be related to the changes I've made. What are your thoughts on this PR? |
Hey, cool. The failing test is because of the move of the Thanks! |
Merged, along with some additional functionality -- Thanks for the patch, appreciated! |
Great work on this library. However I'd really like using the CLI for a quick validation. So I've produced this little CLI tool for validating a JSON document (file) against a JSON schema (file).