Skip to content

What is the reason to not have tests suites as git submodule from json-schema-org? #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ystreibel opened this issue Jul 16, 2019 · 2 comments
Closed

What is the reason to not have tests suites as git submodule from json-schema-org? #583

ystreibel opened this issue Jul 16, 2019 · 2 comments
Labels
Invalid Not a bug, PEBKAC, or an unsupported setup

Comments

@ystreibel
Copy link

Hello,

I compare the tests suites of jsonschema vs json-schema-org repositories. Could you explain why in jsonschema repository the tests suites directory is not a submodule from json-schema-org?

What's the differences between those two tests suites ?
Did you make the effort to maintain both in parallele ?

Thank you !
@Julian
Copy link
Member

Julian commented Jul 16, 2019

The tests are a git subtree, which is essentially a slightly improved version of git submodules.

@Julian
Copy link
Member

Julian commented Jul 20, 2019

Closing but hopefully that answered your question!

@Julian Julian closed this as completed Jul 20, 2019
@Julian Julian added the Invalid Not a bug, PEBKAC, or an unsupported setup label Nov 14, 2019
Julian added a commit that referenced this issue Aug 6, 2022
@Julian
Squashed 'json/' changes from 91ecacf60..0015d5242
9e7387d 
0015d5242 Merge pull request #583 from santhosh-tekuri/defs
e14c68bb4 Replace '$defs' with 'definitions' in drafts 6,7
c4341bd0a Merge pull request #582 from santhosh-tekuri/defs
4ae2c9b93 Replace '$defs' with 'definitions' in draft 6,7

git-subtree-dir: json
git-subtree-split: 0015d5242d146248cb47850a08012b4829462d3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Invalid Not a bug, PEBKAC, or an unsupported setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Julian @ystreibel