Skip to content

Deprecate Validator.is_type #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Julian opened this issue Dec 7, 2018 · 1 comment
Closed

Deprecate Validator.is_type #505

Julian opened this issue Dec 7, 2018 · 1 comment

Comments

@Julian
Copy link
Member

Julian commented Dec 7, 2018

In favor of calling this directly on the type checker.
@Julian
Copy link
Member Author

Julian commented Jan 3, 2019

Bleh while I'd love to do this, it'd encourage validator (function) authors to break the law of demeter, or otherwise to change the signature of validator functions in some way, because all the existing drafts need to guard against specific types.

It still makes me a bit uneasy that type and format have special support in validator construction, but there's no obvious solution that pops to mind for how to get rid of that quite yet.

@Julian Julian closed this as completed Jan 3, 2019
Julian added a commit that referenced this issue Oct 7, 2021
@Julian
Squashed 'json/' changes from 20c1bb1d9..54440eab4
cf88638 
54440eab4 Merge pull request #516 from ChALkeR/chalker/ipv6
e7b22e1c6 Fix the sanity check by pinning.
8891d8107 Merge pull request #519 from json-schema-org/ether/custom-dialect
5f5fccda3 test the format-assertion vocabulary with a custom metaschema
3fcee3868 Merge pull request #512 from json-schema-org/ether/formats-and-non-strings
b349b8797 test that format-assertions are valid with non-string types
8e5b2f10d fix needless inconsistencies in format tests between drafts
02d7cb59a Correct "ref with sibling id" tests
1649470ba More ipv6 tests to increase coverage
7334b4c7e Merge pull request #505 from ChALkeR/chalker/fix-unicode
0fb2d2787 Consolidate optional/unicode into optional/ecmascript-regex
4f8c6d7bf unevaluatedProperties: deep dynamic + refs
9103f3b6f $ref wit id does not test what it is indented to do
f300dd15f Add test "same $anchor with different base uri"
d128f9d7f Add test to check that $id resolved against nearest parent, not just immediate parent
72e31dd20 Merge pull request #515 from json-schema-org/ether/fix-mandatory-format-tests
0173a0835 Revert "by default, "format" only annotates, not validates"
66e813a90 Merge pull request #506 from json-schema-org/ether/formats-non-ascii
9430972bc fix unicode tests in accordance to pattern/patternProperties spec

git-subtree-dir: json
git-subtree-split: 54440eab4d50b80a62cc9f9c561e306cdbb19591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Julian