Skip to content

Add tips and tricks section to user guide #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2019

Conversation

BeyondEvil
Copy link
Contributor

What we talked about @Dude-x

Sometimes it's best to have suggested solutions to common scenarios, instead of trying to shoehorn them into to the plugin.

Fixes: #133

@BeyondEvil BeyondEvil requested review from davehunt and isaulv July 1, 2019 20:21
davehunt
davehunt previously approved these changes Jul 1, 2019
docs/conf.py Outdated
@@ -47,7 +47,7 @@

# General information about the project.
project = u"pytest-selenium"
copyright = u"2015, Dave Hunt"
copyright = u"2019, Dave Hunt"
author = u"Dave Hunt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add other authors here now.. my last commit was almost a year ago.

@isaulv
Copy link
Contributor

isaulv commented Jul 3, 2019

looks good to me. I would probably update this in the future once python 3 is the norm. I think the encode command is for py2 compatibility.

@BeyondEvil BeyondEvil merged commit 8c257f4 into pytest-dev:master Jul 12, 2019
@BeyondEvil BeyondEvil deleted the tips-tricks-section branch July 12, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save screenshot to tempfile in text mode
3 participants