Skip to content

Fix issue with using localhost for TestingBot tunnel #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

BeyondEvil
Copy link
Contributor

Fixes: #216

@BeyondEvil BeyondEvil requested review from davehunt and isaulv February 6, 2019 13:29
@isaulv
Copy link
Contributor

isaulv commented Feb 6, 2019

Is it possible that the port is 443 the standard HTTPS port and no longer custom? I would prefer to try to maintain encryption.

isaulv
isaulv previously approved these changes Feb 6, 2019
Copy link
Contributor

@isaulv isaulv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@BeyondEvil
Copy link
Contributor Author

Is it possible that the port is 443 the standard HTTPS port and no longer custom? I would prefer to try to maintain encryption.

When using TestingBot without a tunnel we use HTTPS and port 443. But what the tunnel does is it enables you to let the TestingBot VM access any webserver running locally on your machine (and not exposed to the public internet).

The tunnel itself is secure and uses SSH to communicate with the TestingBot VM. But for the tests to be able to communicate with the VM (via the tunnel) you have to point the tests to localhost and port 4445 (default, configurable).

So the "unsecured" http-traffic is happening only on your local machine, never with the TB VM.

Testing bot example

Our docs

Let me know if that clears things up @Dude-x

@isaulv
Copy link
Contributor

isaulv commented Feb 7, 2019

Thanks for the clarification.

@BeyondEvil
Copy link
Contributor Author

BeyondEvil commented Feb 7, 2019

Sorry, had to add the changes to news.rst because I want to release a new version asap, to fix this bug. @Dude-x

@BeyondEvil BeyondEvil merged commit fe25750 into pytest-dev:master Feb 8, 2019
@BeyondEvil BeyondEvil deleted the fix-tb-local-tunneling branch February 8, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants