Major version increase?

[staticdev]

Hi,

I've seen 3.3.0 changed name from MockFixture to MockerFixture. It broke existing code like in:
https://github.com/staticdev/toml-validator/pull/157/checks?check_run_id=1020396590

I see at least two possible solutions here: increasing the major version to 4.0.0 to semantically say it broke original API or rename back (maybe even creating some alias to support both names).

[The-Compiler]

Duplicate of #202 - keeping this open for now though.

[staticdev]

I see... sorry for the duplicate. Anyhow, @nicoddemus my test code also uses the type MockFixture to annotate arguments of fixtures such as the example code linked.

[nicoddemus]

Hi @staticdev,

I see... sorry for the duplicate.

No worries!

Anyhow, @nicoddemus my test code also uses the type MockFixture to annotate arguments of fixtures such as the example code linked.

You can't upgrade because you intend to support older pytest-mock versions for now?

I think the only thing we can do to mitigate this is to add an alias, as you suggest, however I would prefer to avoid that because it is another thing to eventually deprecate/remove in the future.

[staticdev]

@nicoddemus I don't intend to support older pytest-mock. Personally, I would go for 4.0.0 and move on.

[nicoddemus]

Problem with that is that I see two scenarios:

1. People who pin to avoid major versions (for example pytest-mock<4): for those people making a new 4.0 release won't do any good, as they will still get 3.3 with MockerFixture.
2. People who don't pin (the vast majority I believe): those will either pin to !=3.3 or just update their code. Again making a 4.0 release won't do much good as they will need to update their code or their pins.

So unless I'm missing something, releasing 4.0 will only bring more confusion than solving any real problem, I think.

[graingert]

Doesn't reveal_type(pytest_mock.plugin.MockFixture) just show Any?

(For the old <3.3.0)

[staticdev]

I pin all my versions. To solve everything you can rename and patch 3.3.0 with 3.3.1 (go back to previous MockFixture.
And then create a 4.0.0 with MockerFixture (if you really want to rename it).

The idea of alias, as you said, comes with more code to maintain.

[nicoddemus]

The idea of alias, as you said, comes with more code to maintain.

Indeed, but just a single line in this case.

@graingert @staticdev please see #205.

[staticdev]

@nicoddemus very well.. that does the trick! So we can close this one.

[nicoddemus]

Feel free to leave your approval there. 😉

[graingert]

The idea of alias, as you said, comes with more code to maintain.

Indeed, but just a single line in this case.

@graingert @staticdev please see #205.

No I mean in @staticdev 's codebase you're not using --disallow-any-unimported which should fail for this unexported symbol

[nicoddemus]

@graingert want to take a look at #205 and see if I'm missing something?