Skip to content

Use pytest's FixtureDef type #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Use pytest's FixtureDef type #863

merged 1 commit into from
Jun 28, 2024

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Jun 24, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (9e254b4) to head (74a0383).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
+ Coverage   95.59%   95.61%   +0.01%     
==========================================
  Files           2        2              
  Lines         477      479       +2     
  Branches       95       96       +1     
==========================================
+ Hits          456      458       +2     
  Misses         12       12              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

I don't think this PR needs a changelog entry since the code changes should only affect developers, but not the users. Or am I missing something?

@seifertm seifertm added this to the v0.23 milestone Jun 28, 2024
@webknjaz
Copy link
Member

I don't think this PR needs a changelog entry since the code changes should only affect developers, but not the users. Or am I missing something?

In pytest itself, I added changelog categories for contributors/downstream folk intended for news/summaries for contributors/core devs. Perhaps, we need to do the same here. But in general, yes, it shouldn't need a change note for the end-users audience.

@seifertm
Copy link
Contributor

I don't think this PR needs a changelog entry since the code changes should only affect developers, but not the users. Or am I missing something?

In pytest itself, I added changelog categories for contributors/downstream folk intended for news/summaries for contributors/core devs. Perhaps, we need to do the same here. But in general, yes, it shouldn't need a change note for the end-users audience.

Interesting idea. I'll have a look how this is done in pytest.

In the meantime, let's get the PR on the road.

@seifertm seifertm added this pull request to the merge queue Jun 28, 2024
Merged via the queue into pytest-dev:main with commit 734fdb0 Jun 28, 2024
14 checks passed
@tamird tamird deleted the fixturedef branch June 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants