-
Notifications
You must be signed in to change notification settings - Fork 159
Fix duplication of markers in async tests #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ewriteWarning. Signed-off-by: Michael Seifert <[email protected]>
90371af
to
f3c89b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
- Coverage 95.61% 92.08% -3.54%
==========================================
Files 2 2
Lines 479 480 +1
Branches 96 96
==========================================
- Hits 458 442 -16
- Misses 12 23 +11
- Partials 9 15 +6 ☔ View full report in Codecov by Sentry. |
… functions. Signed-off-by: Michael Seifert <[email protected]>
f3c89b0
to
d15c9fc
Compare
Thank you for a quick fix! Alas, it didn't fix the bokeh testsuite (at least in my environment). |
@MeggyCal Can you provide a small code example that reproduces the issue? |
Sorry, not easily, I can try next week. Anyway, it is visible in my project on the openSUSE Buildservice: https://build.opensuse.org/project/show/home:mcalabkova:branches:devel:languages:python:numeric |
@MeggyCal A quick look at the logs suggest that the tests due to the following warning:
The warning is most likely unrelated to this PR and probably not a bug either, because the warning exists for some time already. Whether the warning is reasonable or not is an entirely different issue. I'm open for discussing this in a dedicated issue or discussion :) |
@seifertm I took a look in the bokeh issues and found out it is a known issue since December: bokeh/bokeh#13578. So it is merely a consequence of openSUSE not upper-bounding dependencies and there's no need to open another issue. Sorry for the false alarm, I just looked into this repo first and since I saw a fix for a similar-sounding issue, I didn't investigate further and just assumed wrong. Thank you very much for your help! |
Thanks for the investigation, @MeggyCal ! |
Fixes #813