Restore compatibility with pytest>=7.0,<7.2 #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m correctly using the minimum pytest version. The "deps" option does not specify the package dependencies, but a list of packages that should be installed before the package under test. However, it's possible ot use "install_command" to specify a constraints file. see tox-dev/tox#1939 (comment) Signed-off-by: Michael Seifert <[email protected]>
The "consider_mro" keyword argument to _pytest.mark.structures.get_unpacked_marks was only introduced in pytest-7.2.0. Removing the explicit argument from the function call will adjust the behavior of pytest-asyncio marks to that of pytest. Signed-off-by: Michael Seifert <[email protected]>
…unhandled deprecation warnings. Signed-off-by: Michael Seifert <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 2 2
Lines 406 406
Branches 87 87
=======================================
Hits 382 382
Misses 14 14
Partials 10 10
☔ View full report in Codecov by Sentry. |
Carreau
approved these changes
Nov 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest-asyncio v0.22.0 makes use of
_pytest.mark.structures.get_unpacked_marks. It explicitly passes theconsider_mrokeyword argument which has only been added in pytest v7.2. This lead to breakage for users of with pytest>=7.0,<7.2.The error has not been uncovered by the test suite, due to wrong configuration of the pytest-min tox environment.
This PR fixes the pytest-min test environment, adjusts the pinned dependencies for this environment, and issues the call to
get_unpacked_marksin a way that is backwards compatible with older pytest versions.Fixes #654