Fix internal error with module level skips #656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents unrelated tests from aggregating in test_simple.py. Signed-off-by: Michael Seifert <[email protected]>
…ule-level skips. Signed-off-by: Michael Seifert <[email protected]>
|
Would appreciate a ping when this makes it to a release. |
|
The code triggering the internal error no longer exists on main. There are no plans for a patch release for v0.22, so I'm closing this PR as obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps the call to
_pytest.mark.structures.get_unpacked_marksin a try except that handles exceptions raised by pytest related to test outcomes, i.e.pytest.skip(..., allow_module_level=True), or collection errors, e.g. barepytest.skip(...).This is a bit of a bandaid. The best solution would be to not used
get_unpacked_marksat all, or at least call it as part of the test collection phase.Fixes #655