-
Notifications
You must be signed in to change notification settings - Fork 159
Provide typing info #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide typing info #260
Conversation
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 93.13% 93.02% -0.11%
==========================================
Files 3 3
Lines 233 258 +25
Branches 33 33
==========================================
+ Hits 217 240 +23
- Misses 10 12 +2
Partials 6 6
Continue to review full report at Codecov.
|
The PR is green |
Merged, if we require the type info -- better to add it fast, other PRs can use typing from the very beginning. |
That's great thank you very much. Sorry for the lack of response to your question in the first place. |
Type checking is rough, better checks require not released yet pytest 7.0 at least.
Tests are not typed to don't pollute this big enough PR.
They can be typed later.
Fixes #198