Skip to content

Reformat with black #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2022
Merged

Reformat with black #240

merged 1 commit into from
Jan 7, 2022

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Jan 7, 2022

setup.py is also reformatted for the sake of uniformness.

@Tinche Tinche self-requested a review January 7, 2022 11:41
@asvetlov asvetlov merged commit 02d8f10 into master Jan 7, 2022
@asvetlov asvetlov deleted the black branch January 7, 2022 11:42
@Tinche
Copy link
Member

Tinche commented Jan 7, 2022

@asvetlov LGTM. As for the workflow, would you like me to just approve and leave the merging to you, or merge too?

@asvetlov
Copy link
Contributor Author

asvetlov commented Jan 7, 2022

Up to you.
In CPython, we usually prefer to give the PR author to decide when pressing the merge button if the author is a core developer.
The rule is not strict though, sometimes we can violate the rule if the feature is desirable to land quickly.
Regarding self requests, there is another rule: wait for a day at least if nobody the PR reviewed yet. Again, the rule is soft.

I'm pretty sure other mature Open Source projects have a similar practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tinche Tinche Tinche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvetlov @Tinche