Fix #168: 1) respect user case that provides specific event loop policy, 2) add a new unitary test to check it #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To take into account user case that sets a specific event loop policy before runnins pytest asyncio tests: - Rollover changes in V0.14 (that clears event loop policy in pytest_fixture_post_finalizer) - include a new unit test that checks if policy has been changed (fails with V0.14 and pass with this PR).
|
Hi @Tinche Apologise. Please close this PR, we would proceed discussions in policies branch. |
|
Let's move the discussion to #174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Tinche
Let me know if this PR can be helpful to support the project.
Please let me know your thoughts or share the solution you are working on.
Don't hesitate to let me know what's the best way to help