Unused TCP port factory fixture. Bump to 0.2.0. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def factory(): | ||
| port = unused_tcp_port() | ||
| while port in produced: | ||
| port = unused_tcp_port |
There was a problem hiding this comment.
I think this should be port = unused_tcp_port().
There was a problem hiding this comment.
Good catch! Of course the bug is in the section not tested. I'll add a test and get coverage up to 100%.
|
Hmm coverage has decresed by 2%, but I can't access the source when I try to access coveralls... |
|
Looks good to me, nice work! 😄 |
|
(Not sure if I was supposed to merge it) |
nicoddemus
added a commit
that referenced
this pull request
Aug 2, 2015
Unused TCP port factory fixture. Bump to 0.2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to simplify the new fixture a little; now it's a callable which returns a different port each invocation.
@nicoddemus Could you please do a small review before merging?