-
Notifications
You must be signed in to change notification settings - Fork 132
Update tensor.where
to allow for case with only condition
#844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 80.89% 80.89%
=======================================
Files 169 169
Lines 46979 46984 +5
Branches 11478 11480 +2
=======================================
+ Hits 38002 38007 +5
- Misses 6764 6767 +3
+ Partials 2213 2210 -3
|
Needs a test |
should i also be testing for cases where ift and iff are being passed or only for the new case which we deal with? |
Yeah that makes sense, and also test the error case |
in the case where it should raise an exception, it is correctly doing that but the |
|
everything seems to be working fine now. lmk if any more changes are required or if some implementation should be done differently |
tensor.where
to allow for case with only condition
Thanks @tanish1729 |
Description
Allows
tensor.where
to work similar tonp.where
in case only a condition is givenRelated Issue
tensor.where
does not behave likenp.where
when only one input (condition) is passed #829Checklist
Type of change