Skip to content

Only consider main branch in README test badge #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

Prtm2110
Copy link
Contributor

@Prtm2110 Prtm2110 commented Jun 18, 2024

The README badge now shows if the latest tests on the main branch passed.

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@twiecki
Copy link
Member

twiecki commented Jun 18, 2024

Thanks!
Isn't it using the main branch by default anyway?

@ricardoV94
Copy link
Member

Thanks!
Isn't it using the main branch by default anyway?

Nope, it was using the most recent tests, usually from a draft PR.
At least it was doing that when I opened the original issue

@maresb
Copy link
Contributor

maresb commented Jun 28, 2024

@Prtm2110, could you please fix the title of this PR?

@Prtm2110 Prtm2110 changed the title Test badge in the README is now ensures that it reflects the most reflects the most recent test specific to the main branch. Update Test badge in the README Jun 29, 2024
@ricardoV94 ricardoV94 changed the title Update Test badge in the README Only consider main branch in README Ttest badge Jul 13, 2024
Co-authored-by: Ricardo Vieira <[email protected]>
@maresb maresb changed the title Only consider main branch in README Ttest badge Only consider main branch in README test badge Jul 14, 2024
@ricardoV94 ricardoV94 merged commit 308bc01 into pymc-devs:main Jul 14, 2024
2 checks passed
@ricardoV94
Copy link
Member

Thanks @Prtm2110

@Prtm2110
Copy link
Contributor Author

Thanks @ricardoV94 for my first PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test badge in Readme is not showing last test on main
4 participants