Grad error message #721
Closed
Grad error message #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the nlinalg file
|
@ricardoV94 I still seem to getting all my old commits on the new branch I used. Since this is just a one-line fix for the issue, can we just go through the changes here and finish this. I'll make a new PR for a different issue after this and make sure these mistakes dont happen |
ricardoV94
reviewed
Apr 17, 2024
| @@ -357,7 +358,10 @@ def grad( | |||
| .. [1] Giles, Mike. 2008. “An Extended Collection of Matrix Derivative Results for Forward and Reverse Mode Automatic Differentiation.” | |||
|
|
|||
| """ | |||
| raise NotImplementedError() | |||
| # raise NotImplementedError() | |||
There was a problem hiding this comment.
This is my suggestion for a simpler solution
Suggested change
| # raise NotImplementedError() | |
| raise NotImplementedError(f"grad not implemented for Op {self}") |
There was a problem hiding this comment.
Also your implementation was wrong because it assumed there is a single input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a new branch and added
grad_not_implementedfor a helpful error messageRelated Issue
Checklist
Type of change