Add codecov_token env variable to upload coverage report #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianopaz
force-pushed
the
codecov_token
branch
from
315682d to
92a5e61
Compare
|
Should the codecov bot have left a message or we never enabled that? |
The codecov bot does not seem to be installed on pytensor. Do we want to have it? |
Yeah I think it would be nice |
|
Ok, I just installed the codecov bot for this repo. New PRs from now on should get the codecov bot reply with the coverage chart
|
ricardoV94
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #714
From looking at this failed coverage report upload, the codecov action was saying that we were not using the upload token when we tried to upload the coverage reports. To be honest, I have no idea why we were ever able to upload the reports without setting the token. I've added the token as an action secret and placed it as an env variable for that step of the upload job.