Skip to content

Adding Op in message when grad is not implemented #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Adding Op in message when grad is not implemented #719

wants to merge 16 commits into from

Conversation

tanish1729
Copy link
Contributor

Description

Using the grad_not_implemented function in the Op to give a helpfui error message

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@tanish1729
Copy link
Contributor Author

@ricardoV94 did i mess up somewhere in making this PR? the old changes are also somehow a part of this when it should just be one commit for the thing i actually did this time

@ricardoV94
Copy link
Member

@tanish1729 your PR seems to be coming from your main branch. Usually you should create a new branch for every PR, from a main branch that is synced with the current main of PyTensor, specially if you are working on multiple PRs at the same time. That branch should only include the new commits.

Feel free to close this PR and try again.

@ricardoV94
Copy link
Member

These instructions are for the PyMC repository, but you may find it helpful here to, many of the steps are the same: https://www.pymc.io/projects/docs/en/stable/contributing/pr_tutorial.html

@tanish1729 tanish1729 closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Op in message when raising NotImplementedError from grad
2 participants