Fix mypy problem on Windows due to platform differences #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in <pymc-devs#678 (comment)>, mypy was failing on Windows due to an unnecessary type: ignore. This fixes it by ignoring the unused-ignore so that Windows is covered.
|
@HarshvirSandhu and @Dhruvanshu-Joshi, I think this will fix the pre-commit issues you've been having. |
ricardoV94
approved these changes
Apr 12, 2024
|
That's so sneaky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported in #678 (comment), mypy was failing on Windows due to an unnecessary
# type: ignore. This fixes it by ignoring theunused-ignoreso that Windows is covered.I'm marking this as maintenance since it's not a runtime bugfix.
Related Issue
Fixes an issue introduced and reported in #678.
Checklist
Type of change