Correct the example in the "Adding JAX and Numba support for Ops" doc #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example as it was threw a type error because the registered function is called with `node` and `output_storage` keyword arguments, which were not included in the function signature. Adding a `**kwargs` argument resolves this, and is also what the existing Jaxified Ops all seem to do.
|
Check out #654 (comment) |
|
Closing in favor of #687 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it was written, this example demonstrating how to add JAX support for the
EyeOpthrew a type error, because it registered with JAX a function that only takes a single argumentop, which is actually called with the keyword argumentsnodeandoutput_storageas well. Adding a**kwargsto the function signature resolves this, and is also what the existing Jaxified Ops mostly seem to do.Type of change