Make Split a view op #344
Merged
Make Split a view op #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
ricardoV94
changed the title
ricardoV94
added
enhancement
ricardoV94
force-pushed
the
fix_split_numba
branch
from
0286eb8 to
aca5c04
Compare
This allows the outputs to be views of the inputs. The Python and Numba implementation do that, but the C still performs a copy
ricardoV94
force-pushed
the
fix_split_numba
branch
from
aca5c04 to
3249de0
Compare
aseyboldt
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343
Originally I was forcing a copy in the Numba implementation, but it makes more sense to make the Split Op a view on the inputs.
The C implementation does not exploit this, but we could if we wanted. Because of this, C graphs may become a bit more inefficient because they can no longer inplace on the outputs of
Spliteven if these are always copies for now.