Skip to content

Include Op in message when raising NotImplementedError from grad #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

Aarsh-Wankar
Copy link
Contributor

@Aarsh-Wankar Aarsh-Wankar commented Mar 21, 2025

Added an error message f"grad not implemented for Op {self}" in the NotImplementedError for the grad function of Op class.

Description

This change helps in finding the Op which has an unimplemented grad when many Ops are strung together.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1314.org.readthedocs.build/en/1314/

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.99%. Comparing base (b75c18f) to head (0410b3c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files         188      188           
  Lines       48506    48506           
  Branches     8672     8672           
=======================================
  Hits        39771    39771           
  Misses       6583     6583           
  Partials     2152     2152           
Files with missing lines Coverage Δ
pytensor/graph/op.py 88.08% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit cb0758c into pymc-devs:main Mar 24, 2025
74 checks passed
@ricardoV94
Copy link
Member

Thanks @Aarsh-Wankar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Op in message when raising NotImplementedError from grad
2 participants