Fix einsum failing with repeated inputs

[Abhinav-Khot]

Description

Fixed the issue where passing the same tensor multiple times as arguments to the einsum function would raise a ValueError. Implemented a function that internally converts duplicate objects into copies using copy().

Related Issue

• Closes Einsum fails with repeated inputs #1217
• Related to #

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pytensor--1260.org.readthedocs.build/en/1260/

[Abhinav-Khot]

@ricardoV94 @twiecki

Hello maintainers,

My pull request seems to fail 2 tests even though these aren't directly linked to any changes I have made. This is my first time contributing, I would appreciate any help

[ricardoV94]

It's unrelated and will be patched by a0d9ecf

[ricardoV94]

Some small optimization. Don't assume a list is passed and reduce list access. Also is should be better than ==.

Suggested change

	for i in range(len(elements)):
	for j in range(i + 1, len(elements)):
	if elements[i] == elements[j]:
	elements[j] = elements[j].copy()
	return elements
	elements = list(elements)
	n_elem = len(elements)
	for i, elem1 in enumerate(elements[:-1]):
	for j, elem2 in enumerate(elements[i + 1:], start=i+1):
	if elem1 is elem2:
	elements[j] = elem1.copy()
	return elements

[ricardoV94]

Can you add a regression test?

[ricardoV94]

Failing test should go away with a rebase from main

[ricardoV94]

You seem to have pushed a pyd file by mistake

[Abhinav-Khot]

@ricardoV94 I have deleted that file, thank you for noticing that

[ricardoV94]

Still needs a regression test

[Abhinav-Khot]

Still needs a regression test

Just to clarify, does this mean I need to add a test to the test_einsum.py to check functionality? Again apologies, this is my first time contributing.

[ricardoV94]

Still needs a regression test

Just to clarify, does this mean I need to add a test to the test_einsum.py to check functionality? Again apologies, this is my first time contributing.

Yes, a test that would fail before this PR. Try to make it a simple as possible

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.99%. Comparing base (2a7f3e1) to head (30aaffc).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
- Coverage   81.99%   81.99%   -0.01%     
==========================================
  Files         188      188              
  Lines       48553    48582      +29     
  Branches     8673     8688      +15     
==========================================
+ Hits        39812    39833      +21     
- Misses       6579     6585       +6     
- Partials     2162     2164       +2     

Files with missing lines	Coverage Δ
pytensor/tensor/einsum.py	97.10% <100.00%> (+0.10%)	⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ricardoV94]

Thanks @Abhinav-Khot