Skip to content

Presentation for linalg rewrites #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

Presentation for linalg rewrites #38

merged 2 commits into from
Mar 18, 2025

Conversation

jessegrabowski
Copy link
Member

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ricardoV94
Copy link
Member

Looks good, I would just add some links:

  1. https://pytensor.readthedocs.io/en/latest/gallery/rewrites/graph_rewrites.html
  2. https://github.com/pymc-devs/pymc/blob/af81955f799e1fba1adcf839454ccc0be851008a/pymc/math.py#L452

And perhaps:

  • Use pytensor.config.optimizer_verbose=True throughout this notebook. You can exclude the useless stuff with pytensor.config.optimizer_verbose_ignore="MergeOptimizer,constant_folding,..." whatever is irrelevant?

@jessegrabowski jessegrabowski merged commit db952a6 into main Mar 18, 2025
@jessegrabowski jessegrabowski deleted the linalg-rewrites branch March 18, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 Awaiting requested review from ricardoV94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessegrabowski @ricardoV94