Allow interdependent initial points from same OpFromGraph node #7569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not part of the API that variables must be registered in topological order
ricardoV94
force-pushed
the
nested_toposort_replace
branch
from
95d3dde to
285263d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7569 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 106 106
Lines 17669 17681 +12
=======================================
+ Hits 16403 16415 +12
Misses 1266 1266
|
zaxtax
approved these changes
Nov 15, 2024
| @@ -187,6 +193,40 @@ def test_string_overrides_work(self): | |||
| assert np.isclose(iv["B_log__"], 0) | |||
| assert iv["C_log__"] == 0 | |||
|
|
|||
| @pytest.mark.parametrize("reverse_rvs", [False, True]) | |||
| def test_dependent_initval_from_OFG(self, reverse_rvs): | |||
There was a problem hiding this comment.
Is this test indicative of why this features is need for the other PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to allow proper initival support of Marginalized variables in pymc-devs/pymc-extras#388, where multiple interdependent variables may become collapsed in a single node. We want initial values replacements to still propagate across these dependencies.
To achieve that the initial point machinery now makes use of
toposort_replace(instead of assuming model variables are provided in a topological order) and the utility itself is expanded to untie variables coming from the same OpFromGraph node📚 Documentation preview 📚: https://pymc--7569.org.readthedocs.build/en/7569/