Add logcdf implementation for Truncated distributions #6690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6690 +/- ##
==========================================
- Coverage 92.01% 92.00% -0.01%
==========================================
Files 95 95
Lines 16000 16043 +43
==========================================
+ Hits 14722 14761 +39
- Misses 1278 1282 +4
|
ricardoV94
approved these changes
Apr 27, 2023
ricardoV94
reviewed
Apr 27, 2023
pymc/distributions/truncated.py
Outdated
| base_rv_op = op.base_rv_op | ||
| logcdf = _logcdf(base_rv_op, value, *rv_inputs, **kwargs) | ||
|
|
||
| # For left truncated RVs, we don't want to include the lower bound in the |
There was a problem hiding this comment.
Suggested change
| # For left truncated RVs, we don't want to include the lower bound in the | |
| # For left truncated discrete RVs, we don't want to include the lower bound in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR adds the logcdf implementation of Truncated distributions. Addresses #6686.
The CDF here is calculated as:
(F(x) - F(a))/(F(b) - F(a)),where F(x) is the CDF of the base distribution with infinite support.
Checklist
New features
📚 Documentation preview 📚: https://pymc--6690.org.readthedocs.build/en/6690/