Skip to content

Remove versioneer from requirements.txt #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Sep 17, 2022

Context: Versioneer was added in #6078, installed in "vendored mode" so that the necessary code is installed into versioneer.py.

It seems strange to me that versioneer is an install requirement. It looks like nothing breaks when I remove it.

In order to enable CI, I had to add requirements.txt to the list of test-triggering files in .github/workflows/tests.yml.

What is this PR about?
...

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • Remove (apparently) unnecessary versioneer requirement
  • Trigger CI on a PR which modifies requirements.txt

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #6135 (e4ce1d4) into main (5236d3e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6135   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         101      101           
  Lines       20945    20945           
=======================================
  Hits        19459    19459           
  Misses       1486     1486           

@maresb maresb marked this pull request as ready for review September 17, 2022 13:05
@twiecki twiecki merged commit 4c92adf into pymc-devs:main Sep 17, 2022
@twiecki
Copy link
Member

twiecki commented Sep 17, 2022

Thanks!

@maresb maresb deleted the fix-versioneer-reqs branch September 17, 2022 19:16
@maresb maresb added the no releasenotes Skipped in automatic release notes generation label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants