Skip to content

Default to pm.Data(mutable=False), deprecate MLDA and bump to v4.1.0 #5944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2022

Conversation

michaelosthege
Copy link
Member

What is this PR about?
When attempting to bump the version to 4.1.0, I ran into a change f the pm.Data(mutable=...) default setting that we had already announced to happen in 4.1.0.

Consequently, I made that change and adapted tests accordingly.

I also sneaked in a DeprecationWarning about moving MLDA over to pymc-experimental (#5942).

Checklist

Major / Breaking Changes

  • pm.Data() now defaults to mutable=False (use pm.ConstantData/pm.MutableData or pass mutable=True/False to avoid a warning).

Bugfixes / New features

None

Docs / Maintenance

  • Added a DeprecationWarning about moving MLDA to pymc-experimental.
  • __version__ was incremented to "4.1.0"

@michaelosthege michaelosthege added release maintenance major Include in major changes release notes section labels Jul 3, 2022
@michaelosthege michaelosthege added this to the v4.1.0 milestone Jul 3, 2022
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #5944 (65f999e) into main (f617180) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5944      +/-   ##
==========================================
+ Coverage   89.52%   89.54%   +0.01%     
==========================================
  Files          73       73              
  Lines       13271    13271              
==========================================
+ Hits        11881    11883       +2     
+ Misses       1390     1388       -2     
Impacted Files Coverage Δ
pymc/__init__.py 100.00% <100.00%> (ø)
pymc/data.py 81.48% <100.00%> (-0.16%) ⬇️
pymc/model.py 88.20% <100.00%> (+0.14%) ⬆️
pymc/step_methods/mlda.py 96.38% <100.00%> (+0.01%) ⬆️
pymc/step_methods/hmc/base_hmc.py 90.55% <0.00%> (+0.78%) ⬆️

@twiecki
Copy link
Member

twiecki commented Jul 3, 2022

Can you do the bump in a separate PR?

@michaelosthege
Copy link
Member Author

Can you do the bump in a separate PR?

Why that? The other changes should come before 4.1.0.

Also, I'm confident the CI will go green this time (I tried that one test locally..)
Just had to push again, because I forgot to fixup a commit.

@michaelosthege
Copy link
Member Author

I shpuld clarify: The 4.1.0 bump depends on some of these changes. I tried just bumping first, but the tests went red..

@michaelosthege
Copy link
Member Author

Thomas wanted to get another PR merged beforehand - that's done so I'm merging this one now.

@michaelosthege michaelosthege merged commit d974861 into pymc-devs:main Jul 3, 2022
@michaelosthege michaelosthege deleted the bump410 branch July 3, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance major Include in major changes release notes section release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants