Skip to content

Compute some basic Slice sample stats #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

ricardoV94
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #5889 (577c46b) into main (338ec15) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5889   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          73       73           
  Lines       13228    13234    +6     
=======================================
+ Hits        11837    11843    +6     
  Misses       1391     1391           
Impacted Files Coverage Δ
pymc/backends/ndarray.py 79.46% <ø> (-0.19%) ⬇️
pymc/step_methods/slicer.py 96.20% <100.00%> (+0.36%) ⬆️
pymc/step_methods/compound.py 86.66% <0.00%> (-6.67%) ⬇️
pymc/sampling.py 82.41% <0.00%> (-0.12%) ⬇️
pymc/parallel_sampling.py 86.79% <0.00%> (+0.33%) ⬆️
pymc/step_methods/hmc/base_hmc.py 90.47% <0.00%> (+0.79%) ⬆️
pymc/step_methods/arraystep.py 94.32% <0.00%> (+1.41%) ⬆️

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Eventually, we should check the dtypes when they're emitted, but the test you implemented is a start.

@ricardoV94 ricardoV94 merged commit fb3e65f into pymc-devs:main Jun 13, 2022
@ricardoV94 ricardoV94 deleted the slice_sampler_stats branch June 6, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants