Skip to content

Prior predictions constant data #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Prior predictions constant data #5723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d4fc37
support return constant_data with prior pred
TimOliverMaier Apr 21, 2022
b93588f
pre-commit format
TimOliverMaier Apr 21, 2022
7f6abd4
added test
TimOliverMaier Apr 21, 2022
1588e1f
code review
TimOliverMaier Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pymc/backends/arviz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,6 @@ def observed_data_to_xarray(self):
default_dims=[],
)

@requires(["trace", "predictions"])
@requires("model")
def constant_data_to_xarray(self):
"""Convert constant data to xarray."""
Expand Down
3 changes: 2 additions & 1 deletion pymc/tests/test_idata_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ def test_no_trace(self):

@pytest.mark.parametrize("use_context", [True, False])
def test_priors_separation(self, use_context):
"""Test model is enough to get prior, prior predictive and observed_data."""
"""Test model is enough to get prior, prior predictive, constant_data and observed_data."""
with pm.Model() as model:
x = pm.MutableData("x", [1.0, 2.0, 3.0])
y = pm.ConstantData("y", [1.0, 2.0, 3.0])
Expand All @@ -514,6 +514,7 @@ def test_priors_separation(self, use_context):
"prior": ["beta", "~obs"],
"observed_data": ["obs"],
"prior_predictive": ["obs"],
"constant_data": ["x", "y"],
}
if use_context:
with model:
Expand Down