Skip to content

fixed numpy docstring for class weibull #5466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

ravichikkam
Copy link
Contributor

@ravichikkam ravichikkam commented Feb 13, 2022

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

Note: doing numpy doc validation for weibull class in distributions/continuous.py

#DataUmbrellaPyMCSprint

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #5466 (6e4dd1b) into main (9a066e7) will not change coverage.
The diff coverage is n/a.

❗ Current head 6e4dd1b differs from pull request most recent head 84fe47b. Consider uploading reports for the commit 84fe47b to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5466   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files          82       82           
  Lines       13941    13941           
=======================================
  Hits        11188    11188           
  Misses       2753     2753           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 96.88% <ø> (ø)

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ravichikkam , thanks for the PR, I hope it was an enjoyable experience. I have two quick comments.

  1. Can you add the close figs context to the plot directive as shown in https://pymc-data-umbrella.xyz/en/latest/sprint/docstring_tutorial.html#section-independent-comments?

  2. Can you go to Update docstrings for better rendering on website and numpydoc compliance #5459 and comment you are working on the Weibull docstring, Also for future contributions do this before starting to work on that, otherwise we might find two PRs working on the same simultaneously and be forced to discard one of them.

@ravichikkam
Copy link
Contributor Author

Thanks for the comment. I am very excited to be contributing to open source for the very first time.
I made the changes to add close-figs context and also made a comment on #5459 on WIP on weibull docstring.
Please let me know if this needs more changes.

@OriolAbril OriolAbril merged commit 3bdc175 into pymc-devs:main Feb 16, 2022
@OriolAbril
Copy link
Member

Thanks @ravichikkam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants