Fix failing MAP when only a subset of variables is used #5445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced tolerance for optimization that includes discrete variable in `test_find_MAP_discrete`. It is unclear whether the original reference had a theoretical/empirical meaning or just happened to be the result obtained when the test was created.
Codecov Report
@@ Coverage Diff @@
## main #5445 +/- ##
==========================================
- Coverage 81.41% 81.40% -0.02%
==========================================
Files 82 82
Lines 14214 14216 +2
==========================================
- Hits 11573 11572 -1
- Misses 2641 2644 +3
|
twiecki
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced tolerance for optimization that includes discrete variable in
test_find_MAP_discrete. It is unclear whether the original reference had a theoretical/empirical meaning or just happened to be the result obtained when the test was created.Since the less stable Powell method is used in that case, and since the result is still pretty close to the original reference, I think it's safe to just lower the test threshold.
Closes #4771