API backports and deprecation warnings #5389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
changed the title
Lognormal→LogNormal
OriolAbril
reviewed
Jan 27, 2022
| @@ -5,6 +5,7 @@ | |||
| + The `pm.logp(rv, x)` syntax is now available and recommended to make your model code `v4`-ready. Note that this backport is just an alias and much less capable than what's available with `pymc >=4` (see [#5083](https://github.com/pymc-devs/pymc/pulls/5083)). | |||
| + The `pm.Distribution(testval=...)` kwarg was deprecated and will be replaced by `pm.Distribution(initval=...)`in `pymc >=4` (see [#5226](https://github.com/pymc-devs/pymc/pulls/5226)). | |||
| + The `pm.sample(start=...)` kwarg was deprecated and will be replaced by `pm.sample(initvals=...)`in `pymc >=4` (see [#5226](https://github.com/pymc-devs/pymc/pulls/5226)). | |||
| + `pm.Lognormal` is now available as an alias for `pm.Lognormal` (see [#5389](https://github.com/pymc-devs/pymc/pull/5389)). | |||
There was a problem hiding this comment.
Capitalization is wrong, I think the first one should be LogNormal
| @@ -9,7 +9,7 @@ dependencies: | |||
| - mkl-service | |||
| - nbsphinx>=0.4 | |||
| - numpy=1.15 | |||
| - numpydoc>=0.9 | |||
| - numpydoc<1.2 | |||
There was a problem hiding this comment.
Would using numpydoc! =1.2.0 allow installation of 1.2.1? The PR fix was merged today, the patch release should hopefully not take long, and with that we could forget about the pin completely
There was a problem hiding this comment.
While they labeled it 1.2.0 on GitHub, the PyPI release is just 1.2, so I'm not sure if !=1.2.0 would work.
Also we have the <1.2 on main already.
But I'm now "watching" the numpydoc repo and will get a notification 🔔 when they do the next release.
|
@OriolAbril can we merge this? |
OriolAbril
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some simple backports to reduce API breakage in the
v3→v4transition.