Skip to content

Revamp our negative binomial explanation (#5300) #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

herve-91
Copy link
Contributor

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColCarroll does this look good from the math side?

@ericmjl
Copy link
Member

ericmjl commented Jan 23, 2022

Having used the NB distribution in multiple places, I can confirm that the explanation is correct. Though, I'm not @ColCarroll and not a mathematician either, I will defer to @ColCarroll!

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #5365 (02043e3) into main (d52655d) will increase coverage by 3.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5365      +/-   ##
==========================================
+ Coverage   80.36%   83.45%   +3.08%     
==========================================
  Files          89      132      +43     
  Lines       14808    26070   +11262     
==========================================
+ Hits        11901    21757    +9856     
- Misses       2907     4313    +1406     
Impacted Files Coverage Δ
pymc/distributions/discrete.py 98.77% <ø> (ø)
pymc/parallel_sampling.py 86.71% <0.00%> (-1.00%) ⬇️
pymc/distributions/continuous.py 96.93% <0.00%> (-0.50%) ⬇️
pymc/step_methods/metropolis.py 82.97% <0.00%> (-0.08%) ⬇️
pymc/distributions/__init__.py 100.00% <0.00%> (ø)
pymc/distributions/distribution.py 91.40% <0.00%> (ø)
pymc/tests/test_variational_inference.py 0.00% <0.00%> (ø)
pymc/tests/test_tuning.py 96.42% <0.00%> (ø)
pymc/tests/test_posteriors.py 100.00% <0.00%> (ø)
pymc/tests/test_data_container.py 99.53% <0.00%> (ø)
... and 43 more

@michaelosthege michaelosthege merged commit eb5177a into pymc-devs:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants