Adding moment for Moyal distribution and corresponding tests #5179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
ricardoV94
reviewed
Nov 13, 2021
pymc/distributions/continuous.py
Outdated
| @@ -3727,6 +3727,14 @@ def dist(cls, mu=0, sigma=1.0, *args, **kwargs): | |||
|
|
|||
| return super().dist([mu, sigma], *args, **kwargs) | |||
|
|
|||
| def get_moment(rv, size, mu, sigma): | |||
| mu, sigma = at.broadcast_arrays(mu, sigma) | |||
There was a problem hiding this comment.
Suggested change
| mu, sigma = at.broadcast_arrays(mu, sigma) |
This is not needed here. The parameters will be automatically broadcasted below as long as they show up in the same expression
There was a problem hiding this comment.
Removed. Thanks.
ricardoV94
changed the title
Codecov Report
@@ Coverage Diff @@
## main #5179 +/- ##
==========================================
- Coverage 78.09% 78.06% -0.03%
==========================================
Files 88 88
Lines 14149 14171 +22
==========================================
+ Hits 11050 11063 +13
- Misses 3099 3108 +9
|
ricardoV94
approved these changes
Nov 14, 2021
|
Looks good. Waiting to see if the tests pass |
|
Thanks for the help @jlopezarriaza! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Moyla moment and corresponding tests to help with #5078