Skip to content

Reenable more tests #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2021
Merged

Reenable more tests #4770

merged 2 commits into from
Jun 15, 2021

Conversation

ricardoV94
Copy link
Member

Some tests were mistakenly marked as --ignore. I have re-enabeld them. We should fix the outdated comments in pytest.yml. @michaelosthege feel free to push to this PR

@ricardoV94
Copy link
Member Author

Also found that find_MAP is failing quite often after the V4 refactoring. Most issues seem to boil down to gradients of discrete vars and/or models with both discrete and continuous unobserved variables. The failing tests are marked with an xfail for the time being.

@ricardoV94 ricardoV94 mentioned this pull request Jun 14, 2021
Closed
michaelosthege
michaelosthege approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardoV94 I updated the comments. Take a look to check if they now explain how this works.

@michaelosthege michaelosthege merged commit 7e35cdd into pymc-devs:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelosthege michaelosthege michaelosthege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardoV94 @michaelosthege