Remove redundant log1pexp reimplementation in Logistic CDF #4406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: Reorder logp and random to be in line with rest of the library
twiecki
approved these changes
Jan 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #4406 +/- ##
==========================================
- Coverage 88.15% 88.15% -0.01%
==========================================
Files 88 88
Lines 14565 14564 -1
==========================================
- Hits 12840 12839 -1
Misses 1725 1725
|
AlexAndorra
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementation seems unnecessary given log1pexp/softplus is already implemented in Theano.
In addition, after aesara-devs/aesara#262 the exact same algorithm will be used in the Theano default implementation.
Note: I also sorted the random and logp methods to be in line with most of the distributions in the library.