Skip to content

Remove pymc3/examples #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Conversation

MarcoGorelli
Copy link
Contributor

xref #4348 (comment)

This PR does a few things:

  • the pymc3/examples/data files which were used in tests have been moved to pymc3/tests/data, so that those tests (pymc3/tests/test_examples.py) can continue running as before
  • any other file which might have been accessed by pm.get_data is now in pymc-examples - if someone tries to open it using pm.get_data, it'll be downloaded from pymc-examples. This keeps get_data backwards-compatible whilst lightening the PyPI package
  • all other files have been removed from pymc3/examples, as they're already in the pymc-examples repo

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #4352 (c2e31aa) into master (4e5edd5) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4352      +/-   ##
==========================================
- Coverage   87.95%   87.93%   -0.02%     
==========================================
  Files          88       88              
  Lines       14499    14506       +7     
==========================================
+ Hits        12752    12756       +4     
- Misses       1747     1750       +3     
Impacted Files Coverage Δ
pymc3/data.py 80.26% <66.66%> (-0.75%) ⬇️

@fonnesbeck
Copy link
Member

LGTM

@michaelosthege michaelosthege merged commit 4e435ea into pymc-devs:master Dec 20, 2020
@MarcoGorelli MarcoGorelli deleted the remove-examples branch December 20, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants