Add GitHubAction to auto-update hooks, and other cleanups #4314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Dec 8, 2020
Comment on lines
+11
to
+12
| env: | ||
| SKIP: no-commit-to-branch |
There was a problem hiding this comment.
this hook is just so that you don't accidentally make a commit to the master branch when developing locally, it needs to be skipped during CI as after PRs are merged the jobs are run from the master branch
Codecov Report
@@ Coverage Diff @@
## master #4314 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 88 88
Lines 14274 14274
=======================================
Hits 12500 12500
Misses 1774 1774
|
twiecki
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should replicate the 'autoupdate' feature we would've got from pre-commit-ci in #4312
Also, adding in some assorted cleanups while I'm here, and slightly reordering tests
got a test failure on the first, trying again to see if it's flaky (=> open new issue) or if it needs fixing immediately