fix regression #4273 #4297
Merged
fix regression #4273 #4297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4297 +/- ##
==========================================
- Coverage 87.69% 87.69% -0.01%
==========================================
Files 88 88
Lines 14341 14355 +14
==========================================
+ Hits 12576 12588 +12
- Misses 1765 1767 +2
|
michaelosthege
approved these changes
Dec 5, 2020
There was a problem hiding this comment.
looks like a good workaround! It works on my machine too.
I can't test MacOS.
Together with #4269 this should get us into stable territory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #4273 by ensuring that our tests don't attempt parallel sampling when a bound method was used as
logpinput toDensityDist. Additionally, I added some informative warnings about a previously rather obscure issue.It would be good to see whether this now allows tests to run on MacOS/Windows as well.
@rpgoldman @aseyboldt @MarcoGorelli @michaelosthege